Repository navigation
fix(mcp): make the deferred tools revision on first use - #77
Merged
Merged
Conversation
Workers reject random values in global scope, so deploying main failed with "Disallowed operation called within global scope" at worker/knowledge/deferred-tools.mjs:11. The per-isolate revision is now created on first use. A test fails if loading the module makes a random value.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
multillm-proxy | 9d94815 | Oct 09 2026, 11:04 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merging #14 to main did not deploy. Workers Builds ran
wrangler deploy, and Cloudflare rejected the upload:Production kept running the previous version, so nothing broke.
Line 11 created a random per-isolate revision at module load (
const processRevision = crypto.randomUUID()). It is now created on first use, so it keeps the same meaning: one random revision per isolate.Why CI missed it
cloudflare-buildjob only runswrangler deploy --dry-run, which bundles the Worker but never evaluates its global scope.wrangler versions uploadcannot apply.So nothing loaded the full Worker before the production upload.
Tests
tests/test_deferred_tools_worker.mjsfails if loading the module makes a random value. It fails on main and passes here.npm run test:worker: 1,891 passed.wrangler dev --localboots the full Worker here. On main it fails to start with the same error Cloudflare reported.